Skip to content

Conversation

@TaylorWatson
Copy link
Member

Summary

  • update the tabs component library to target .NET 9 and consume the corresponding Blazor packages
  • modernize the tab components with nullable annotations, async activation helpers, and improved cascading usage to better support Blazor auto render mode
  • streamline shared imports for LINQ and Task usage while keeping the ITab contract up to date

Testing

  • dotnet build (fails: dotnet command not available in container)

https://chatgpt.com/codex/tasks/task_e_68e728da7ec48332a19e4916828e1433

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

<CascadingValue Value=this>
<div class="@(NavWrapperClass)">
<nav class="@Class" aria-label="@(AriaLabel)">
<CascadingValue Value="this">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Cascade passes string literal instead of component instance

The <CascadingValue> declaration now sets Value="this". Adding quotes turns the expression into the literal string "this", so no TailBlazorTabs instance is provided to descendants. As a result TailBlazorTab’s [CascadingParameter] remains null, and OnInitialized will throw when it tries to access ContainerTabs.DefaultTabClass, breaking tab initialization. The attribute should remain Value=this (without quotes) so the component instance is cascaded.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant